revert: "fix: update action button to use grid area to position notifi… #8552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuiliao
changed the title
|
Build successful! 🎉 |
reidbarber
approved these changes
Jul 15, 2025
LFDanLu
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so grid areas + position absolute + buttons + firefox apparently don't mix well
see reported bugs (i was also able to reproduce as well in the most recent version of firefox)
https://bugzilla.mozilla.org/show_bug.cgi?id=1883204
https://bugzilla.mozilla.org/show_bug.cgi?id=1712594
we'll need to figure out another way to do this without using grid areas
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: