-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update lightningcss #4070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lightningcss #4070
Conversation
Build successful! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update looks fine. Not sure the best way to test this, other than docs and storybook build and thinks look correct. I assume Chromatic was run and everything passes?
Thanks for the reminder, Chromatic shows bad. We have some new specificity collisions |
This reverts commit ff0f269.
Build successful! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested link in Safari. looks good
Build successful! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, link shows double underline when focused now and chromatic looks good. Maybe a opportunity to use the docs-differ to check that the rest of the docs don't have any unforeseen visual changes
Build successful! 🎉 |
## API Changes
unknown top level export { type: 'identifier', name: 'Column' } |
ran docs differ, seems good to me |
update lightnincss
* Adding parseDuration functionality Adds parseDuration function to internationalized/date package to parse ISO 8601 Duration strings into a DateTimeDuration object * separating parseDuration documentation to separate PR * corrects formatting issues * corrects documentation for parseDuration function * fix deps in @react-types/list (#4073) * fix(#4067): Storybook Provider addon: Express input:checkbox requires id to be labelled by htmlFor prop (#4068) * Explain Proxy in TableView (#4072) Explain proxy usage in TableView * Update lightningcss (#4070) update lightnincss * fix(#4078): MobileComboBox: searchbox should not have aria-expanded property (#4079) * Get rid of dupe id in DatePicker/useDatePicker (#4085) * Getting rid of duplicated id present in presentational element * generate a separate id instead to avoid useField complaining in useDateField a date field in a datepicker/rangepicker gets the field props removed from it, but we still need to call useField in useDateField which will complain that there isnt a aria labelledby so we still need to pass the field props * Code changes from docs-ts branch (#4090) * Add docs to more pages, and small wording updates --------- Co-authored-by: Daniel Lu <dl1644@gmail.com> Co-authored-by: Danni <drobinson@livefyre.com> Co-authored-by: Reid Barber <reid@reidbarber.com> Co-authored-by: Michael Jordan <mijordan@adobe.com> Co-authored-by: Robert Snow <rsnow@adobe.com> Co-authored-by: Devon Govett <devongovett@gmail.com>
Closes #3991
Figured it was a good opportunity to update parcel as well. However, if we want to restrict it, I can do that as well.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: