Skip to content

Code changes from docs-ts branch #4090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2023
Merged

Code changes from docs-ts branch #4090

merged 1 commit into from
Feb 21, 2023

Conversation

devongovett
Copy link
Member

Code changes from #3710

devongovett
devongovett commented Feb 21, 2023
View reviewed changes
packages/@internationalized/date/src/CalendarDate.ts
@@ -42,6 +42,7 @@ export class CalendarDate {
// This prevents TypeScript from allowing other types with the same fields to match.
// i.e. a ZonedDateTime should not be be passable to a parameter that expects CalendarDate.
// If that behavior is desired, use the AnyCalendarDate interface instead.
// @ts-ignore
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ignores the "unused variable" error which comes up due to the tsconfig for the docs checker.

@rspbot
Copy link

rspbot commented Feb 21, 2023

Build successful! 🎉

@rspbot
Copy link

rspbot commented Feb 21, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

@react-aria/listbox

getItemId

 AriaListBoxOptions<T> {
   isVirtualized?: boolean
   keyboardDelegate?: KeyboardDelegate
-  label?: ReactNode
-  onAction?: (Key) => void
   shouldFocusOnHover?: boolean
   shouldSelectOnPressUp?: boolean
   shouldUseVirtualFocus?: boolean
 }

ListBoxSectionAria

-
+AriaListBoxProps<T> {
+  autoFocus?: boolean | FocusStrategy
+  label?: ReactNode
+  onAction?: (Key) => void
+  selectionBehavior?: SelectionBehavior
+  shouldFocusWrap?: boolean
+}

it changed:

  • useListBoxSection

@react-aria/menu

AriaMenuProps

-
+AriaMenuProps<T> {
+  autoFocus?: boolean | FocusStrategy
+  onAction?: (Key) => void
+  onClose?: () => void
+  shouldFocusWrap?: boolean
+}

@react-aria/overlays

useOverlayTrigger

 useOverlayTrigger {
   props: OverlayTriggerProps
   state: OverlayTriggerState
-  ref: RefObject<Element>
+  ref?: RefObject<Element>
   returnVal: undefined
 }

@react-spectrum/tabs

TabPanels

 SpectrumTabsProps<T> {
   children: ReactNode
   density?: 'compact' | 'regular'
   disabledKeys?: Iterable<Key>
+  isDisabled?: boolean
   isEmphasized?: boolean
   isQuiet?: boolean
   items?: Iterable<T>
   keyboardActivation?: 'automatic' | 'manual' = 'automatic'
 }

LFDanLu
LFDanLu approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

snowystinger
snowystinger approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the docs pages for each of these, looks good

@devongovett devongovett merged commit 3f3e83f into main Feb 21, 2023
@devongovett devongovett deleted the docs-ts-code branch February 21, 2023 23:33
@dannify dannify removed the release label Feb 22, 2023
devongovett added a commit to adobesamr/react-spectrum that referenced this pull request Feb 22, 2023
@devongovett
Code changes from docs-ts branch (adobe#4090)
6e4c37d
dannify added a commit that referenced this pull request Feb 23, 2023
@adobesamr @LFDanLu
@dannify @reidbarber @snowystinger @devongovett
Adds parseDuration documentation (#3844)
e209b3d 
* Adding parseDuration functionality

Adds parseDuration function to internationalized/date package to parse
ISO 8601 Duration strings into a DateTimeDuration object

* separating parseDuration documentation to separate PR

* corrects formatting issues

* corrects documentation for parseDuration function

* fix deps in @react-types/list (#4073)

* fix(#4067): Storybook Provider addon: Express input:checkbox requires id to be labelled by htmlFor prop (#4068)

* Explain Proxy in TableView (#4072)

Explain proxy usage in TableView

* Update lightningcss (#4070)

update lightnincss

* fix(#4078): MobileComboBox: searchbox should not have aria-expanded property (#4079)

* Get rid of dupe id in DatePicker/useDatePicker (#4085)

* Getting rid of duplicated id present in presentational element

* generate a separate id instead to avoid useField complaining in useDateField

a date field in a datepicker/rangepicker gets the field props removed from it, but we still need to call useField in useDateField which will complain that there isnt a aria labelledby so we still need to pass the field props

* Code changes from docs-ts branch (#4090)

* Add docs to more pages, and small wording updates

---------

Co-authored-by: Daniel Lu <dl1644@gmail.com>
Co-authored-by: Danni <drobinson@livefyre.com>
Co-authored-by: Reid Barber <reid@reidbarber.com>
Co-authored-by: Michael Jordan <mijordan@adobe.com>
Co-authored-by: Robert Snow <rsnow@adobe.com>
Co-authored-by: Devon Govett <devongovett@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snowystinger snowystinger snowystinger approved these changes

@LFDanLu LFDanLu LFDanLu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devongovett @rspbot @snowystinger @LFDanLu @dannify