Skip to content

Surface useOverlayPosition's updatePosition from usePopover #3872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Surface useOverlayPosition's updatePosition from usePopover #3872

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/@react-aria/overlays/src/usePopover.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@ export interface PopoverAria {
/** Props to apply to the underlay element, if any. */
underlayProps: DOMAttributes,
/** Placement of the popover with respect to the trigger. */
placement: PlacementAxis
placement: PlacementAxis,
/** Updates the position of the overlay. */
updatePosition(): void
}

/**
Expand All @@ -84,7 +86,7 @@ export function usePopover(props: AriaPopoverProps, state: OverlayTriggerState):
popoverRef
);

let {overlayProps: positionProps, arrowProps, placement} = useOverlayPosition({
let {overlayProps: positionProps, arrowProps, placement, updatePosition} = useOverlayPosition({
...otherProps,
targetRef: triggerRef,
overlayRef: popoverRef,
Expand Down Expand Up @@ -116,6 +118,7 @@ export function usePopover(props: AriaPopoverProps, state: OverlayTriggerState):
popoverProps: mergeProps(overlayProps, positionProps),
arrowProps,
underlayProps,
placement
placement,
updatePosition
};
}