Surface useOverlayPosition's updatePosition from usePopover #3872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'updatePosition' is still important when using popovers, eg if using react transitiongroup for a popover, as the position cannot be calculated while the contents is not mounted. This commit surfaces the callback.
|
As this PR is only to surface a property already public, I don't think there's any tests/docs to update - but happy to if needed. 👍 |
|
Thanks for the PR. For the build to pass you'll need to sign the CLA, then close and re-open this PR to let it refresh. |
|
Please reopen this when the CLA is signed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'updatePosition' is still important when using popovers, eg if using react transitiongroup for a popover, as the position cannot be calculated while the contents is not mounted. This PR surfaces the callback.
✅ Pull Request Checklist: