Skip to content

@react-types/shared/collections: fix return types of KeyboardDelegate #3139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2022
Merged

@react-types/shared/collections: fix return types of KeyboardDelegate #3139

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3235a16
@react-types/shared/collections: fix return types of KeyboardDelegate
dlech May 17, 2022
03418b2
Merge branch 'main' into patch-1
snowystinger Jun 6, 2022
d811352
Merge branch 'main' into patch-1
snowystinger Jun 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions packages/@react-types/shared/src/collections.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,31 +89,31 @@ export type SortDirection = 'ascending' | 'descending';

export interface KeyboardDelegate {
/** Returns the key visually below the given one, or `null` for none. */
getKeyBelow?(key: Key): Key,
getKeyBelow?(key: Key): Key | null,

/** Returns the key visually above the given one, or `null` for none. */
getKeyAbove?(key: Key): Key,
getKeyAbove?(key: Key): Key | null,

/** Returns the key visually to the left of the given one, or `null` for none. */
getKeyLeftOf?(key: Key): Key,
getKeyLeftOf?(key: Key): Key | null,

/** Returns the key visually to the right of the given one, or `null` for none. */
getKeyRightOf?(key: Key): Key,
getKeyRightOf?(key: Key): Key | null,

/** Returns the key visually one page below the given one, or `null` for none. */
getKeyPageBelow?(key: Key): Key,
getKeyPageBelow?(key: Key): Key | null,

/** Returns the key visually one page above the given one, or `null` for none. */
getKeyPageAbove?(key: Key): Key,
getKeyPageAbove?(key: Key): Key | null,

/** Returns the first key, or `null` for none. */
getFirstKey?(key?: Key, global?: boolean): Key,
getFirstKey?(key?: Key, global?: boolean): Key | null,

/** Returns the last key, or `null` for none. */
getLastKey?(key?: Key, global?: boolean): Key,
getLastKey?(key?: Key, global?: boolean): Key | null,

/** Returns the next key after `fromKey` that matches the given search string, or `null` for none. */
getKeyForSearch?(search: string, fromKey?: Key): Key
getKeyForSearch?(search: string, fromKey?: Key): Key | null
}

/**
Expand Down