Skip to content

Conversation

@dlech
Copy link
Contributor

@dlech dlech commented May 17, 2022

As noted in the doc comments, the return values for each of the methods in KeyboardDelegate can return null. This fixes the typings by adding null to the return types.

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

As noted in the doc comments, the return values for each of the methods in KeyboardDelegate can return null. This fixes the typings by adding null to the return types.
@reidbarber
Copy link
Member

Thanks for submitting! If you sign the CLA and close/re-open this it should build

@dlech dlech closed this May 18, 2022
@dlech dlech reopened this May 18, 2022
Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR! We're are looking into making our own tsconfig strict in the future so hopefully we'll be more consistent with these null typings

@snowystinger snowystinger merged commit 26990c2 into adobe:main Jun 6, 2022
@dlech dlech deleted the patch-1 branch June 6, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants