Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the exportLogDataToJSON supporting the ZonedDateTime format #185

Closed
mickaelgobbo opened this issue Oct 4, 2024 · 2 comments · Fixed by #186
Closed

make the exportLogDataToJSON supporting the ZonedDateTime format #185

mickaelgobbo opened this issue Oct 4, 2024 · 2 comments · Fixed by #186
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@mickaelgobbo
Copy link
Collaborator

Expected Behaviour

This should be fine to have the different exportLogDataToJSON method supporting the java.time.ZonedDateTime format.

Actual Behaviour

Currently it's not the case, and in the structure of the logData which need to be exported, if a java.time.ZonedDateTime is present, we have the issue:

Encountered error while exporting the log data to a JSON file.
Caused by: com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Java 8 date/time 
type `java.time.ZonedDateTime` not supported by default: add Module "com.fasterxml.jackson.datatype:jackson-datatype-jsr310" to enable handling (through 
reference chain: java.util.ArrayList[0]->java.util.HashMap["timestamp"])
@mickaelgobbo mickaelgobbo added the enhancement New feature or request label Oct 4, 2024
@baubakg baubakg added the bug Something isn't working label Oct 4, 2024
@baubakg baubakg added this to the 1.11.0 milestone Oct 4, 2024
@baubakg
Copy link
Member

baubakg commented Oct 4, 2024

problem reproduced

@baubakg
Copy link
Member

baubakg commented Oct 4, 2024

Two elements:

  • We should be resilient, as in we need to throw errors in a correct fashion. There should be a dedicated exception, with proper workaround mechanisms
  • We should use the Jacksons java8 datetime mechanisms

@baubakg baubakg linked a pull request Oct 4, 2024 that will close this issue
8 tasks
baubakg added a commit that referenced this issue Oct 4, 2024
…ta (#186)

* Fixed issue #185 : We now have a string transformer when exporting data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants