Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #185 : We now have a string transformer when exporting data #186

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

baubakg
Copy link
Member

@baubakg baubakg commented Oct 4, 2024

Description

Due to errors when serializing unexpected objects, we have chosen to transform all data to String when exporting.

Related Issue

Fixes #185

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.99%. Comparing base (93bf799) to head (1c3a148).

Files with missing lines Patch % Lines
...m/adobe/campaign/tests/logparser/core/LogData.java 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main     #186   +/-   ##
=========================================
  Coverage     96.98%   96.99%           
- Complexity      375      377    +2     
=========================================
  Files            22       22           
  Lines           961      964    +3     
  Branches        125      125           
=========================================
+ Hits            932      935    +3     
  Misses           18       18           
  Partials         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mickaelgobbo mickaelgobbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's working now, thanks.

@baubakg baubakg merged commit f15336a into main Oct 4, 2024
5 checks passed
Copy link

sonarcloud bot commented Oct 4, 2024

@baubakg baubakg deleted the 185-make-the-exportlogdatresilient branch October 4, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make the exportLogDataToJSON supporting the ZonedDateTime format
3 participants