Remove deprecated file system APIs #9622
Conversation
| @@ -314,7 +309,7 @@ define(function (require, exports, module) { | |||
| }); | |||
|
|
|||
| // Check for updates | |||
| if (!params.get("skipUpdateCheck") && !brackets.inBrowser) { | |||
| if (!brackets.inBrowser && !params.get("skipUpdateCheck")) { | |||
There was a problem hiding this comment.
This was a part of the auto-install extensions PR, but was reverted during review. Since I was editing this file, I thought I would go ahead and restore it.
There was a problem hiding this comment.
Fwiw, there's basically zero chance that this will make any performance difference. But it's not a big deal to change either way.
|
I should note I have already contacted all affected extension authors about the deprecation and eventual removal. |
|
@le717 Here's my list of all the extensions that will break with this PR:
Can you verify that you've filed bugs with all of them already? [edit: I added "(filed)" next to the ones where I see bugs linked back to #6127 -- for the others I'm not sure whether any bug has been filed yet] |
|
@peterflynn It looks like I've issues for most of these, unless GitHub is not showing some of the link backs. Will file the remaining.
|
|
@peterflynn I've contacted the rest of the extension authors. A few of them already had been filed (as denoted by the link to it), and I followed up on the report.
|
|
@peterflynn Do you still want to get this into 1.1? I want to avoid a repeat of the 1.0 issues as much as you do, and if 1.1 is supposed to be released near December 9, the sooner this lands the better chance we have of less extension breakage. |
|
cfbrackets has no reference to NativeFileSystem anymore since 7th jun From: Triangle717 [mailto:notifications@github.com] @peterflynn https://github.com/peterflynn I've contacted the rest of the extension authors. A few of them already had been filed (as denoted by the link to it), and I followed up on the report.
— |
|
@raeberli Thanks for the update. :) |
|
This PR has been coming up on a year open and two years since the old file system was deprecated. Any extensions that are not updated by now will probably never be updated. Could someone perhaps look at this and see about getting it merged? |
|
Agreed @le717 , lets clear this. Merging into master, will take effect from 1.6 (1.5 is now on release branch) |
Remove deprecated file system APIs
Towards #8751.
Removes APIs listed in #6127. As you can see in that issue, there are a number of extensions that access it, but it's nearly a year since they were deprecated. It's time to remove them.