Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Remove deprecated file system APIs #8576

Open
core-ai-bot opened this issue Aug 30, 2021 · 9 comments
Open

[CLOSED] Remove deprecated file system APIs #8576

core-ai-bot opened this issue Aug 30, 2021 · 9 comments

Comments

@core-ai-bot
Copy link
Member

Issue by le717
Tuesday Oct 21, 2014 at 19:10 GMT
Originally opened as adobe/brackets#9622

Towards #8751.

Removes APIs listed in #6127. As you can see in that issue, there are a number of extensions that access it, but it's nearly a year since they were deprecated. It's time to remove them.

le717 included the following code: https://github.com/adobe/brackets/pull/9622/commits
@core-ai-bot
Copy link
Member Author

Comment by le717
Thursday Oct 30, 2014 at 17:22 GMT

I should note I have already contacted all affected extension authors about the deprecation and eventual removal.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Friday Oct 31, 2014 at 23:56 GMT

@le717 Here's my list of all the extensions that will break with this PR:

  • (filed) brackets-docco - FileIndexManager, NativeFileSystem
  • brackets-typescript-code-intel - FileIndexManager, NativeFileSystem
  • jhatwich.brackets-related-files - FileIndexManager
  • (filed) aem-sightly-brackets-extension - NativeFileSystem
  • (filed) alexsalas.brackets-jekyll - NativeFileSystem
  • (filed) brackets-bower - NativeFileSystem
  • brackets-minify-more - NativeFileSystem
  • cfbrackets.org - NativeFileSystem
  • dehats.appcachebuddy - NativeFileSystem
  • (filed) dehats.ccextbuilder - NativeFileSystem

Can you verify that you've filed bugs with all of them already?

[edit: I added "(filed)" next to the ones where I see bugs linked back to #6127 -- for the others I'm not sure whether any bug has been filed yet]

@core-ai-bot
Copy link
Member Author

Comment by le717
Saturday Nov 01, 2014 at 00:11 GMT

@peterflynn It looks like I've issues for most of these, unless GitHub is not showing some of the link backs. Will file the remaining.

brackets-docco - FileIndexManager, NativeFileSystem
brackets-typescript-code-intel - FileIndexManager, NativeFileSystem
jhatwich.brackets-related-files - FileIndexManager (jhatwich/brackets-related-files#3)
alexsalas.brackets-jekyll - NativeFileSystem
brackets-bower - NativeFileSystem
brackets-minify-more - NativeFileSystem
cfbrackets.org - NativeFileSystem
dehats.appcachebuddy - NativeFileSystem (davidderaedt/appcache-gen#1)
dehats.ccextbuilder - NativeFileSystem

@core-ai-bot
Copy link
Member Author

Comment by le717
Saturday Nov 15, 2014 at 17:02 GMT

@peterflynn I've contacted the rest of the extension authors. A few of them already had been filed (as denoted by the link to it), and I followed up on the report.

  • brackets-typescript-code-intel I personally submitted PRs to fix any deprecated code, but they have not been pushed to the registry because of another broken part.
  • brackets-minify-more is a fork of https://github.com/wylst/brackets-minifier. The upstream version has long been updated, but as the fork has issues I cannot directly file a report.@Fornace Would you mind looking into this pending removal and updating your extension appropriately?
    * cfbrackets.org Appears to have already been fixed from Deprecated filesystem APIs raeberli/cfbrackets#1.@raeberli Can you confirm this deprecation will not effect your extensions?

@core-ai-bot
Copy link
Member Author

Comment by le717
Thursday Nov 20, 2014 at 21:55 GMT

@peterflynn Do you still want to get this into 1.1? I want to avoid a repeat of the 1.0 issues as much as you do, and if 1.1 is supposed to be released near December 9, the sooner this lands the better chance we have of less extension breakage.

@core-ai-bot
Copy link
Member Author

Comment by raeberli
Friday Dec 19, 2014 at 20:34 GMT

cfbrackets has no reference to NativeFileSystem anymore since 7th jun

From: Triangle717 [mailto:notifications@github.com]
Sent: Samstag, 15. November 2014 18:03
To: adobe/brackets
Cc: raeberli
Subject: Re: [brackets] Remove deprecated file system APIs (#9622)

@peterflynn https://github.com/peterflynn I've contacted the rest of the extension authors. A few of them already had been filed (as denoted by the link to it), and I followed up on the report.

—
Reply to this email directly or view it on GitHub adobe/brackets#9622 (comment) . https://github.com/notifications/beacon/ACEfRgqF6tHrMgsYqb6EwlXpsbUTKvm4ks5nN360gaJpZM4CxWkQ.gif

@core-ai-bot
Copy link
Member Author

Comment by le717
Saturday Dec 20, 2014 at 03:05 GMT

@raeberli Thanks for the update. :)

@core-ai-bot
Copy link
Member Author

Comment by le717
Tuesday Sep 22, 2015 at 15:07 GMT

This PR has been coming up on a year open and two years since the old file system was deprecated. Any extensions that are not updated by now will probably never be updated. Could someone perhaps look at this and see about getting it merged?

@core-ai-bot
Copy link
Member Author

Comment by zaggino
Tuesday Sep 22, 2015 at 20:00 GMT

Agreed@le717 , lets clear this. Merging into master, will take effect from 1.6 (1.5 is now on release branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot