Themes in Core v1 #8302
Themes in Core v1 #8302
Conversation
This works by checking if the “theme” field exists in the package.json to determine if the extension ought to be treated as a theme or not.
So that we can preemptively figure out if the extension is a theme or a regular extension.
…rresponding folders.
…js to FileLoader.js
…enable multi select
|
@dangoor Awesome! I will go through those follow up items and work my way through them. |
|
@dangoor We should add in the list the migration to the fonts api |
|
This is awesome! Can't wait to see this in the release. Major props @MiguelCastillo! 💥 |
|
@MiguelCastillo We could either add a new issue for that or just modify the existing pull request (#8305) |
|
I'll test this today. Great timing! |
| * @private | ||
| * Verifies if an extension is a theme based on the presence of the field "theme" | ||
| * in the package.json. If it is a theme, then the theme file is just loaded by the | ||
| * ThemeManager |
|
@MiguelCastillo I went through all the JSDocs and gave you some feedback. |
|
@TomMalbran Thanks for your feedback! Definitely helpful. I wasn't sure how to do the one for array of themes. :) |
|
@TomMalbran I will make these adjustments part of the PR for the font api if that's ok |
|
Sure. But might be nice to have good JSDocs before the next version so that the API Docs are accurate. |
|
You don't think we will be landing this one soon? |
|
Sorry, not this one... Font api PR |
|
I don't know. I hope it does. |
|
Hmmm, that could a problem... There is cleanup in Themes that's pending on the font API. And this issue #8381 |
|
Yeah, it's probably safe to assume it'll have to land in this sprint since it's fixing issues that we don't want to ship with... |
|
@peterflynn Awesome! |
Fresh branch from a clean master