Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

[Themes] Restore Font Size (Ctrl+0) no longer works #8381

Closed
redmunds opened this issue Jul 14, 2014 · 6 comments
Closed

[Themes] Restore Font Size (Ctrl+0) no longer works #8381

redmunds opened this issue Jul 14, 2014 · 6 comments
Labels
fixed but not closed
Milestone
Release 0.42

Comments

@redmunds
Copy link
Contributor

I just synced to master and Restore Font Size (Ctrl+0) no longer works, so I'm assuming this is related to Themes work.
@peterflynn peterflynn added this to the Release 0.42 milestone Jul 14, 2014
@peterflynn
Copy link
Member

Adding 0.42 milestone since we think this is a regression

@dangoor
Copy link
Contributor

dangoor commented Jul 15, 2014

cc @MiguelCastillo

@MiguelCastillo
Copy link
Contributor

Yup, I am merging latest into fonts PR and this is next on my list

@MiguelCastillo
Copy link
Contributor

So this issue with this one is that Themes takes over the fonts elements that brackets creates. This is a leftover from the code being an extension and brackets not providing an interface to interact with font settings.
https://github.com/adobe/brackets/blob/master/src/view/ThemeView.js#L48

This issue will go away when we get this #8305 done

This was referenced Jul 15, 2014
Merged
Closed
Merged
@dangoor
Copy link
Contributor

dangoor commented Jul 22, 2014

This is fixed on master by #8492.

FBNC to @redmunds

@redmunds
Copy link
Contributor Author

Confirmed. Closing.

This was referenced Aug 30, 2021
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
fixed but not closed
Projects
None yet
Milestone
Release 0.42
Development

No branches or pull requests
4 participants
@dangoor @redmunds @peterflynn @MiguelCastillo