This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix update notification for not localized languages #7811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That fixes the problem. It's too late now, but there is something wrong with the unit tests, since I was never able to reproduce the behavior that I saw (the always handler being called). I might have overlooked something when mocking $.ajax. I assume, that there is something missing to trigger the always handler. |
ingorichter
added a commit
that referenced
this pull request
May 11, 2014
Fix update notification for not localized languages
|
@ingorichter I debugged the test a bit and saw that, for some reason, it's running synchronous. |
|
@SAplayer Which would explain why the tests didn't catch this issue. I wonder what is wrong with the tests. Perhaps the way I'm mocking the ajax call is plainly wrong. |
|
@ingorichter Fix for the tests is up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7810.