Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Multiple issues with localized UpdateNotification #7810

Closed
marcelgerber opened this issue May 10, 2014 · 3 comments
Closed

Multiple issues with localized UpdateNotification #7810

marcelgerber opened this issue May 10, 2014 · 3 comments

Comments

@marcelgerber
Copy link
Contributor

I just ran into serious issues with the new UpdateNotifications:
Open the dev tools console to look out for errors.

  1. Change lang to e.g. pt-br (does happen with de-DE as well)
  2. Try to search for updates
  3. You'll get an error dialog
  4. In the dev tools, you see pt-br.json, then pt.json, and then pt-br.json again
  5. Change lang to e.g. nl
  6. Retry step 2 and you'll see the results from step 3 again
  7. In the dev tools, you see nl.json, then nl.json again

This is probably a showstopper for Sprint 39

@ingorichter
Copy link
Contributor

Stepping through the code, I can see that the outer .always(..) handler will be called before the inner ajax request has been finished. This will change the url, but the request to load the update notification has already been initiated with the wrong URL. Good catch. I’m going to check your PR later and create a unit test for this.
BTW: do you get de-DE locale on Windows?

@marcelgerber
Copy link
Contributor Author

Yes, I get de-DE on Win 8.1.
The failing complete request is also de-DE.

@marcelgerber
Copy link
Contributor Author

Fixed in release. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants