This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Always select first css value in code hint list #6258
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Contributor
Author
|
@RaymondLim This is ready for review (I was thinking of a different issue). |
Contributor
Author
|
@RaymondLim Oops, I pushed some changes meant for #6239 (which is the other issue I was working on) to this branch. You're signed up to review that one also. Is this ok, or should I keep redo these branches to keep them separate? |
Contributor
|
It's your call. I'm ok that unrelated unit tests being in this pull request. |
Contributor
|
@redmunds Actually, you're mixing fix for url code hinting issue with fix for css code hinting issue, not just the unit tests for url code hinting in this pull request. So could you please separate it into two pull requests? |
Contributor
Author
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #6231
Always select the first value hint. The list of values is usually a relatively short, finite list, so if user happens to want first item in list, this saves them a keystroke.