This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Cbank/initial code coloring #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param {string} fileUrl A cannonical file URL to extract the extension from | ||
| */ | ||
| function _getMimeTypeFromFileExtensions( fileUrl ) { | ||
| require("thirdparty/path-utils/path-utils.min"); |
There was a problem hiding this comment.
By convention, we're putting all the require() calls at the top of the module. This way you can easily see the dependent modules, and quickly check if a needed module has already been require()'d.
| * Does as needed loading and simple dependecy management when loading modes | ||
| * @param {string} mimetype A mimetype that matches one of the available modes | ||
| */ | ||
| function _loadModeForMimeType( mimetype ) { |
There was a problem hiding this comment.
This whole function can go away and be replaced with the require() calls at the top of the module. There is no benefit to conditional module loading here since require.js always pulls all dependencies out, and loads them all, regardless of whether they are needed or not (see http://requirejs.org/docs/api.html#modulenotes and http://requirejs.org/docs/commonjs.html#intro for details).
busykai
added a commit
to busykai/brackets
that referenced
this pull request
Nov 24, 2013
This version is required to load and run brackets properly on node-webkit. See requirejs/text#55 for node-specific details. Summary of changes: > rev to 2.0.10 > Merge pull request adobe#61 from AnSavvides/master > Merge pull request adobe#60 from dakota/patch-1 > rev to 2.0.9 > Merge pull request adobe#55 from busykai/master > Fixes adobe#57 xpcshell: windows FileUtils.File does not like / paths > Rev version for 2.0.7 > Fixes adobe#52, handle non-existent files in node > Fixes issue mentioned in comments for requirejs/r.js#221 about Java usage > Merge pull request adobe#49 from fsbdev/patch-1
dancingfrog
pushed a commit
to Real-Currents/brackets
that referenced
this pull request
Mar 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the adds mode switching based off the file extension.