This repository was archived by the owner on Sep 6, 2021. It is now read-only.
JS changes to prompt user when a native quit, window close, or reload occurs. #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oliter/quit-app * 'tvoliter/quit-app' of github.com:adobe/brackets: Updates for File Close
… direct function calls
| function handleFileQuit(commandData) { | ||
| var deferred = _handleCloseWindowCommon(commandData); | ||
| deferred.done(function quitApp() { | ||
| brackets.app.Quit(); |
There was a problem hiding this comment.
this function should use a lower-case 'q' (quit instead of Quit)
| @@ -58,7 +62,7 @@ define(function (require, exports, module) { | |||
| CommandManager : require("CommandManager") | |||
| }; | |||
|
|
|||
| brackets.inBrowser = !brackets.hasOwnProperty("fs"); | |||
There was a problem hiding this comment.
Did you mean to delete this line?
There was a problem hiding this comment.
That got dropped in a merge from master. I added it back.
gruehle
added a commit
that referenced
this pull request
Feb 8, 2012
JS changes to prompt user when a native quit, window close, or reload occurs.
iwehrman
pushed a commit
to iwehrman/brackets
that referenced
this pull request
Sep 11, 2013
Request up to 100 available themes from Kuler
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be merged with pull request #55 on the brackets-app repo
Changes