Extension Info Column Tweak

[larz0]

See #5147

[njx]

This looks a lot nicer. Looking at it now, though, I wonder if it would make more sense to group the version number with the date, since those are logically related. So how about:

Extension Title
Author
Version x.x.x -- yyyy-mm-dd

(I thought it might be nice to add the label "Version", and there's probably room anyway, but don't feel strongly either way.)

[larz0]

@njx updated and it definitely looks much better now. The author name link competes with the extension name visually but once #4930 is merged then hopefully we can restore balance to this universe.

[njx]

There's redundant code between these two cases, and also we should account for the possibility that there's no userId (although that probably won't happen, the existing code did show something in that case). So I think you could collapse the whole thing into something like:

if (this.metadata && this.metadata.author) {
    result = htmlEscape(this.metadata.author.name || this.metadata.author);
} else if (userId) {
    result = htmlEscape(userId);
}
if (ownerLink) {
    result = "<a href='" + htmlEscape(ownerLink) + "' title='" + htmlEscape(ownerLink) + "'>" + result + "</a>";
}

[njx]

Yup, I like this layout. Just one code review comment.

[njx]

Also, this breaks one of the unit tests due to the format change (ExtensionManager-test, "should populate itself with registry entries and display their fields when created"). I'll push up a fix for that after you've made your fix.

[larz0]

@njx fixed.

[njx]

Fixed unit test. Merging.