Make dialog-filename strings breakable

[redmunds]

This is for #3382. I found several other cases that need the same fix.

[TomMalbran]

It seems like it would be really useful to have a util function that first escapes the url and then breaks it, since there are lots of stacked calls using those functions. An alternative, if possible, would be that breakableUrl, escapes the url before breaking it (maybe adding a new boolean parameter if there are cases where it shouldn't do it).

[redmunds]

@TomMalbran I thought about that, but didn't do anything, so thanks for inspiring me :) I took another look at the code and noticed that htmlEscape() is called every time breakableUrl() is called, so I changed the code to do that automatically.

[TomMalbran]

I checked that too, and it does make sense to always escape the url before breaking it, since when you call breakableUrl() you want to put the string in a template, so htmlEscape() is always needed.

[redmunds]

@TomMalbran Since you've already looked at this one, do you want to officially review it?

[TomMalbran]

It might look better to just replace the errMsg in the Dialog, with these lines and not use the variable, since that is how it does everywhere else. If removing the errString variable too, is good, then we can combine it all without additional variables.

[redmunds]

Good idea. I got rid of errMsg, but left errString.

[TomMalbran]

Sure. I added a few comments there. I found that the Find In Files Label for scoped searches (FindInFiles.js:104) and the Close all documents (DocumentCommandHandlers.js:666) needs a break too. It does look nice in the dialogs and search results.

[redmunds]

Changes pushed.

Good catch on DocumentCommandsHandlers.js:666 -- I only searched the strings.js file for 'dialog-filename'. I also fixed FindInFiles.js104.

[TomMalbran]

Thanks. I did a search for htmlEscape and checked the ones that where urls to find if there were more missing.

This looks great. Merging