Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fixed: #3382 Too long file path breaks dialog filename #3383

Closed
wants to merge 1 commit into from
Closed

Fixed: #3382 Too long file path breaks dialog filename #3383

wants to merge 1 commit into from

Conversation

warpdesign
Copy link

Possible fix for #3382.

@ghost ghost assigned redmunds Apr 10, 2013
@redmunds
Copy link
Contributor

Thanks for reporting and submitting a fix for this bug.

First, you need to sign the CLA before we can accept a fix from you.

I verified that your code somewhat fixes the problem, but it has 2 issues:

  1. It breaks at the beginning of the url even though there's room to display part of it on line
  2. It breaks in the middle of a word -- breaking on a slash is preferred

Also, we already have a solution for this in the method StringUtils.breakableUrl(), but it wasn't getting applied. I submitted pull request #3446 to fix this case and several others, in case you want to take a look.

Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants