This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Allow Quick Open plugins to specify both fileTypes and languageIds #3322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remain backwards compatible with older Brackets builds (prefer languageIds and don't issue deprecation warnings). Also, clean up mis-capitalized var name.
| @@ -142,7 +142,8 @@ define(function (require, exports, module) { | |||
| * cancels Quick Open (via Esc), those changes are automatically reverted. | |||
| */ | |||
| function addQuickOpenPlugin(pluginDef) { | |||
| if (pluginDef.fileTypes) { | |||
| // Backwards compatibility (for now) for old fileTypes field, if newer languageIds not specified | |||
| if (pluginDef.fileTypes && !pluginDef.languageIds) { | |||
ghost
assigned 
|
Looking good - thanks, Peter! |
DennisKehrig
added a commit
that referenced
this pull request
Apr 4, 2013
Allow Quick Open plugins to specify both fileTypes and languageIds
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow Quick Open plugins to specify both fileTypes and languageIds to remain backwards compatible with older Brackets builds (prefer languageIds and don't issue deprecation warnings).
Also, clean up mis-capitalized var name.
@DennisKehrig can you review? This is a cleanup on #3301.