Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Another two straightforward refactoring tasks for Language support #3301

Merged
merged 5 commits into from
Mar 31, 2013

Conversation

WebsiteDeveloper
Copy link
Contributor

@DennisKehrig i completed two other straightforward refactoring tasks one concerning the QuickEdit feature and the other the CSSInlineEditor

@DennisKehrig
Copy link
Contributor

@WebsiteDeveloper Wonderful, I'm excited! :)

Two extensions also use the QuickOpen API:

If you want to, you could submit pull requests to both that can be merged shortly after merging this.
Or add backwards compatibility (and a warning) by safely converting pluginDef.fileTypes to pluginDef.languageIds by mapping the file types to language IDs, I will then open issues in the extensions' repositories and the author can get to them whenever he feels like.

@peterflynn These are your extensions, any comments?

@WebsiteDeveloper
Copy link
Contributor Author

@DennisKehrig i added the backwards compatibility code.

@DennisKehrig
Copy link
Contributor

That was quick, thanks! I'll try to keep up :)

@DennisKehrig
Copy link
Contributor

Sorry for commenting on the commits directly, this makes it confusing to read here.

@DennisKehrig
Copy link
Contributor

Done with my first review!

@WebsiteDeveloper
Copy link
Contributor Author

@DennisKehrig changes pushed

@DennisKehrig
Copy link
Contributor

Looking good, merging!

DennisKehrig added a commit that referenced this pull request Mar 31, 2013
Another two straightforward refactoring tasks for Language support
@DennisKehrig DennisKehrig merged commit 28b9980 into adobe:master Mar 31, 2013
@DennisKehrig
Copy link
Contributor

@WebsiteDeveloper That was an awesome session, thank you very much!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants