This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add feature. Open line above/below the current line. #2729
Merged
Merged
Changes from 12 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
c52fb15
Add feature. Open line above/below the current line (Ctrl-Enter / Ctr…
zeis c4ae5c5
Add unit tests for Open Line feature
zeis 056f84a
Improve Open Line feature. Add additional unit tests.
zeis 8d54428
Invert OpenLine shortcuts
zeis 3b87017
Merge branch 'master' of https://github.com/adobe/brackets into openline
zeis 56f678e
Fix OpenLine problem with inline editors.
zeis 3eea8da
Fix OpenLine undo history
zeis a118ef1
Add few improvements in OpenLine
zeis 6cf215c
Merge upstream updates
zeis 42cd57a
Merge master
zeis f8832d4
Merge branch 'master' of https://github.com/adobe/brackets into openline
zeis 190d58a
Include TomMalbran's suggestions
zeis ebd85e2
Merge branch 'master' of https://github.com/adobe/brackets into openline
zeis 9ebbe08
Add special case for last line in inline editor
zeis 6c0ff04
Merge branch 'master' of https://github.com/adobe/brackets into openline
zeis dd7537a
Include changes to OpenLinecode and new tests
zeis 4de987a
Merge branch 'master' of https://github.com/adobe/brackets into openline
zeis 27321f8
Remove Italian strings for OpenLine. Add little changes to tests.
zeis 5e2d29e
Few cleanups for OpenLine's tests
zeis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These keyboard shortcuts are actually the reverse of what I'd expect. ctrl-enter for open line below and ctrl-shift-enter for open line above. I just fired up Sublime 3 and it agrees with me. From my own usage, I've probably opened lines below 10 times for every time I've opened above...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you on this. I also open lines below more frequently than above. I just kept the same shortcuts as in Visual Studio. I never used Sublime Text.
In the last commit they have been inverted.