Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Add feature. Open line above/below the current line. #2729

Merged
merged 19 commits into from
Apr 22, 2013
Merged

Add feature. Open line above/below the current line. #2729

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
c52fb15
Add feature. Open line above/below the current line (Ctrl-Enter / Ctr…
zeis Jan 30, 2013
c4ae5c5
Add unit tests for Open Line feature
zeis Jan 31, 2013
056f84a
Improve Open Line feature. Add additional unit tests.
zeis Feb 1, 2013
8d54428
Invert OpenLine shortcuts
zeis Feb 12, 2013
3b87017
Merge branch 'master' of https://github.com/adobe/brackets into openline
zeis Feb 15, 2013
56f678e
Fix OpenLine problem with inline editors.
zeis Feb 15, 2013
3eea8da
Fix OpenLine undo history
zeis Feb 16, 2013
a118ef1
Add few improvements in OpenLine
zeis Feb 17, 2013
6cf215c
Merge upstream updates
zeis Feb 28, 2013
42cd57a
Merge master
zeis Mar 14, 2013
f8832d4
Merge branch 'master' of https://github.com/adobe/brackets into openline
zeis Apr 11, 2013
190d58a
Include TomMalbran's suggestions
zeis Apr 11, 2013
ebd85e2
Merge branch 'master' of https://github.com/adobe/brackets into openline
zeis Apr 18, 2013
9ebbe08
Add special case for last line in inline editor
zeis Apr 18, 2013
6c0ff04
Merge branch 'master' of https://github.com/adobe/brackets into openline
zeis Apr 19, 2013
dd7537a
Include changes to OpenLinecode and new tests
zeis Apr 19, 2013
4de987a
Merge branch 'master' of https://github.com/adobe/brackets into openline
zeis Apr 20, 2013
27321f8
Remove Italian strings for OpenLine. Add little changes to tests.
zeis Apr 20, 2013
5e2d29e
Few cleanups for OpenLine's tests
zeis Apr 20, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove Italian strings for OpenLine. Add little changes to tests.
  • Loading branch information
@zeis
zeis committed Apr 20, 2013
commit 27321f84ef49bbc277a30ebb1300bc5983009973
2 changes: 0 additions & 2 deletions src/nls/it/strings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,6 @@ define({
"CMD_BLOCK_COMMENT" : "Commenta/De-commenta blocco",
"CMD_LINE_UP" : "Sposta la riga in alto",
"CMD_LINE_DOWN" : "Sposta la riga in basso",
"CMD_OPEN_LINE_ABOVE" : "Apri linea in alto",
"CMD_OPEN_LINE_BELOW" : "Apri linea in basso",

// View menu commands
"VIEW_MENU" : "Vista",
Expand Down
16 changes: 7 additions & 9 deletions test/spec/EditorCommandHandlers-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ define(function (require, exports, module) {

var myDocument, myEditor;

var testPath = SpecRunnerUtils.getTestPath("/spec/EditorCommandHandlers-test-files");

function setupFullEditor(content, languageId) {
content = content || defaultContent;
languageId = languageId || "javascript";
Expand Down Expand Up @@ -92,7 +94,7 @@ define(function (require, exports, module) {


// Helper functions for creating / closing a window with an inline editor
function createWindowWithInlineEditor(spec, testPath) {
function createWindowWithInlineEditor(spec) {
var promise;

if (!spec.testWindow) {
Expand Down Expand Up @@ -2121,14 +2123,12 @@ define(function (require, exports, module) {

var self = this;

var testPath = SpecRunnerUtils.getTestPath("/spec/EditorCommandHandlers-test-files");

var moveContent = ".testClass {\n" +
" color: red;\n" +
"}";

beforeEach(function () {
createWindowWithInlineEditor(self, testPath);
createWindowWithInlineEditor(self);
});

afterEach(function () {
Expand Down Expand Up @@ -2620,14 +2620,12 @@ define(function (require, exports, module) {

var self = this;

var testPath = SpecRunnerUtils.getTestPath("/spec/EditorCommandHandlers-test-files");

var content = ".testClass {\n" +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you align this strings, and move the testPath to the first describe: describe("EditorCommandHandlers" and remove it from describe("Move Lines Up/Down - inline editor" since it doesn't need to be called twice.

" color: red;\n" +
"}";
" color: red;\n" +
"}";

beforeEach(function () {
createWindowWithInlineEditor(self, testPath);
createWindowWithInlineEditor(self);
});

afterEach(function () {
Expand Down