Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Update CSS Code Hints properties #13344

Merged
merged 2 commits into from
May 3, 2017
Merged

Update CSS Code Hints properties #13344

merged 2 commits into from
May 3, 2017

Conversation

valtlai
Copy link
Contributor

@valtlai valtlai commented Apr 28, 2017

Add properties
all
caret-color
grid-template
hanging-punctuation
isolation
mix-blend-mode
scroll-behavior
tab-size
user-select.

Add values:
clone and slice for box-decoration-break
contents and subgrid for display.

Remove deprecated padding-box from box-sizing.

Fix the order of background-blend-mode.

Add properties
– `all`
– `caret-color`
– `hanging-punctuation`
– `scroll-behavior`
– `tab-size`
– `user-select`.

Add values:
– `clone` and `slice` for `box-decoration-break`
– `contents` for `display`

Remove deprecated `padding-box` from `box-sizing`.
@valtlai valtlai changed the title Update CSS Code Hints Properties Update CSS Code Hints properties Apr 28, 2017
@ficristo ficristo requested review from bemjb and removed request for bemjb April 28, 2017 16:07
Add
– `grid-template`
– `isolation`
– `mix-blend-mode`

Add `subgrid` for `display`

Reorder `background-blend-mode`
@ficristo
Copy link
Collaborator

ficristo commented May 2, 2017

Overall it seems good to me, I'm still not sure if the values inherit, initial, unset should be added or not.
It seems that sometime they were and sometime not.
@swmitra ?

@ficristo ficristo requested a review from swmitra May 2, 2017 18:13
@valtlai
Copy link
Contributor Author

valtlai commented May 2, 2017

@fristo Every CSS property has values inherit, initial, unset and revert. I think they should be added automatically, so we don’t need to list them separately for each property.

@swmitra
Copy link
Collaborator

swmitra commented May 3, 2017

@valtlai Agreed. These 4 values are CSS wide property values and applicable to all properties.
'padding-box' can be removed as most of the modern browsers are skipping this at the moment.
Other changes looks good to me as well.

Good work 👍

@swmitra
Copy link
Collaborator

swmitra commented May 3, 2017

Merging now.

@swmitra swmitra merged commit dc835d5 into adobe:master May 3, 2017
@valtlai valtlai deleted the valtlai/css-props branch May 3, 2017 11:59
@ficristo ficristo added this to the Release 1.10 milestone Jun 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants