Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Update CSS Code Hints properties #11297

Open
core-ai-bot opened this issue Aug 30, 2021 · 4 comments
Open

[CLOSED] Update CSS Code Hints properties #11297

core-ai-bot opened this issue Aug 30, 2021 · 4 comments

Comments

@core-ai-bot
Copy link
Member

Issue by valtlai
Friday Apr 28, 2017 at 11:39 GMT
Originally opened as adobe/brackets#13344


Add properties
all
caret-color
grid-template
hanging-punctuation
isolation
mix-blend-mode
scroll-behavior
tab-size
user-select.

Add values:
clone and slice for box-decoration-break
contents and subgrid for display.

Remove deprecated padding-box from box-sizing.

Fix the order of background-blend-mode.


valtlai included the following code: https://github.com/adobe/brackets/pull/13344/commits

@core-ai-bot
Copy link
Member Author

Comment by ficristo
Tuesday May 02, 2017 at 18:13 GMT


Overall it seems good to me, I'm still not sure if the values inherit, initial, unset should be added or not.
It seems that sometime they were and sometime not.
@swmitra ?

@core-ai-bot
Copy link
Member Author

Comment by valtlai
Tuesday May 02, 2017 at 18:22 GMT


@fristo Every CSS property has values inherit, initial, unset and revert. I think they should be added automatically, so we don’t need to list them separately for each property.

@core-ai-bot
Copy link
Member Author

Comment by swmitra
Wednesday May 03, 2017 at 06:30 GMT


@valtlai Agreed. These 4 values are CSS wide property values and applicable to all properties.
'padding-box' can be removed as most of the modern browsers are skipping this at the moment.
Other changes looks good to me as well.

Good work 👍

@core-ai-bot
Copy link
Member Author

Comment by swmitra
Wednesday May 03, 2017 at 06:31 GMT


Merging now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant