Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

[Core][Quick Open]: There is an extra line under Quick Open bar when resize the window. #5029

Closed
julieyuan opened this issue Sep 3, 2013 · 9 comments
Assignees

Comments

@julieyuan
Copy link

Steps:

  1. Launch Brackets and open a file.
  2. Click Navigate>Quick Open or press Ctrl+Shift+O to invoke Quick Open bar.
  3. Input some invalid file name into the input field to make the border red.
  4. Resize the window of Edge Code.

Result:
There is an extra line under the Quick Open bar and it will move its position with the change of window.

Expected:
There should not have this line.

Notes: This issue also reproduces to Go to Line , Quick Find Definition bar. It always happens on MAC, and sometimes happens on Win. So if you can not see this happening, please try again. Usually it happens when resize Edge Code window from large to small.

ENV: MAC 10.8 and Win8 English OS
Build: 0.31.0-9163 (MAC) and 0.30.0-9131(Win)

Snapshots:
Please refer to snapshots for details:
Win OS:
extra1
MAC OS:
screen shot 2013-09-03 at 2 26 33 am
screen shot 2013-09-03 at 2 26 21 am

@ghost ghost assigned njx Sep 12, 2013
@njx
Copy link
Contributor

njx commented Sep 12, 2013

Yuck! Medium priority to me.

@njx
Copy link
Contributor

njx commented Sep 19, 2013

Nominating for sprint 32.

@njx
Copy link
Contributor

njx commented Sep 24, 2013

That line is actually the collapsed dropdown container, which doesn't move when the window is resized due to #1157.

We could try to hide the container when there's nothing in the dropdown. @larz0, there's a comment in brackets.less in the .smart-autocomplete-container style that says: // the borders show up even if the container is empty, must set height to zero using JS. Do you know if this was actually done at some point in the JS code, or was that something that was intended to be fixed later?

@njx
Copy link
Contributor

njx commented Sep 27, 2013

@larz0 ping - see my last comment

@larz0
Copy link
Member

larz0 commented Sep 27, 2013

@njx I think I added that comment and I can't remember if I got rid of it using Chrome Dev Tools. I'm trying inspect it again but for some reason the modal bar keeps disappearing every time I click on the inspect icon in chrome dev tools. We should definitely hide it if it's empty.

@njx
Copy link
Contributor

njx commented Sep 30, 2013

Changing to low pri and removing from sprint. Not a common combination of steps and it's just a cosmetic issue.

@Zhuyun
Copy link

Zhuyun commented Mar 18, 2014

Tried this issue with 0.38.0.12173 on Win & Mac, still reproduces.

@larz0
Copy link
Member

larz0 commented Mar 29, 2014

@Zhuyun the fix is in master now, could you check again? Thanks.

@Zhuyun
Copy link

Zhuyun commented Mar 31, 2014

Verified with 0.38.0.12421 on Win&Mac. Fixed and close it. Please find screenshots below.
Can't paste any images here. please find them in dropbox.
https://www.dropbox.com/s/asirmqpda9z0abw/Bug5029_Mac_ENU_38_12421.jpg
https://www.dropbox.com/s/khoap3dfilcihic/Bug5029_Win_ENU_38_12421.jpg

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants