GH-249: adding RetryAfterError FeignException type to map 429 http response from Adobe APIs
#250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoisledroff
temporarily deployed
to
prod_oauth_itest
GitHub Actions
Inactive
francoisledroff
temporarily deployed
to
aio_stage_oauth
GitHub Actions
Inactive
shikhartanwar
approved these changes
Sep 17, 2025
francoisledroff
commented
Sep 17, 2025
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| public class RetryAfterError extends FeignException { |
Collaborator
Author
There was a problem hiding this comment.
actually @shikhartanwar we should use the RetryableException instead here
to leverage the Feign retryer see #151
Collaborator
Author
There was a problem hiding this comment.
The default implementation of ErrorDecoder only creates a RetryableExeception instance when the response contains the “Retry-After” header
Member
There was a problem hiding this comment.
But when I checked in the E2E logs it was always an upstream error crafted by us
Collaborator
Author
There was a problem hiding this comment.
yes we had a bug in our ErrorDecoder I worked on a fix here : #251
Collaborator
Author
|
closing it in favor of #251 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for throwing a
RetryAfterErrorFeignExceptionwhen we get429from Adobe APIs allowing clients to handle the exception and retry accordinglyRelated Issue
core: fix retry when429http response from Adobe APIs #249coreimproveFeignUtilBaseBuilderto better tune resiliency #150Motivation and Context
How Has This Been Tested?
Locally
Screenshots (if appropriate):
Types of changes
Checklist: