Skip to content

GH-249 : Throw RetryAfterError exception when we get 429 from upstream service allowing clients to handle the exception and retry accordingly #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
francoisledroff merged 3 commits into from
Sep 17, 2025
Merged

GH-249 : Throw RetryAfterError exception when we get 429 from upstream service allowing clients to handle the exception and retry accordingly #248

francoisledroff merged 3 commits into from
Sep 17, 2025

Conversation

@shikhartanwar
Copy link
Member

@shikhartanwar shikhartanwar commented Sep 17, 2025 •
edited by francoisledroff
Loading

Description

This PR adds support for throwing a RetryAfterError FeignException when we get 429 from Adobe APIs allowing clients to handle the exception and retry accordingly

Related Issue

Motivation and Context

How Has This Been Tested?

Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Shikhar Tanwar added 2 commits September 17, 2025 15:13
Throw RetryAfterError exception when we get throttled by journey
79e6014 
- This allows clients to handle the exception and retry if required
Add unit tests
fe336b1
@shikhartanwar shikhartanwar self-assigned this Sep 17, 2025
@francoisledroff francoisledroff changed the title Throw RetryAfterError exception when we get 429 from upstream service allowing clients to handle the exception and retry accordingly GH-249 : Throw RetryAfterError exception when we get 429 from upstream service allowing clients to handle the exception and retry accordingly Sep 17, 2025
@francoisledroff francoisledroff changed the base branch from main to GH-249 September 17, 2025 10:31
@francoisledroff francoisledroff merged commit c79d2d3 into adobe:GH-249 Sep 17, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@shikhartanwar shikhartanwar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shikhartanwar @francoisledroff