Skip to content

Conversation

shazron
Copy link
Member

@shazron shazron commented Mar 20, 2025

How Has This Been Tested?

  • tested and used internally
  • for commented code issues, see this

⚠️ Do not delete the branch after this is merged (yet) since it is still referenced. A PR will go out to any npm git branch references so it can be updated to the released version of this library, an upcoming v5.4.0.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (937ee2f) to head (5f74825).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #99   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          543       551    +8     
  Branches        15        15           
=========================================
+ Hits           543       551    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@amulyakashyap09 amulyakashyap09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are commented, hope they won't be an issue . Rest looks good!

@shazron
Copy link
Member Author

shazron commented Mar 25, 2025

Some tests are commented, hope they won't be an issue . Rest looks good!

I already mentioned this in the description though

@shazron shazron merged commit d207d02 into master Mar 26, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants