Skip to content

need to verify all api specs exist for function bindings in the library #101

Open
@shazron

Description

@shazron

This PR introduced a regression where the xr-api was missing: #99

Error:

 Getting Application Extensions...
 ›   Error: ***CoreConsoleAPISDK:ERROR_GET_APPLICATION_EXTENSIONS*** TypeError: 
 ›   this.sdk.apis.Extensions.get_console_organizations__orgId__xr_api_v1_app 
 ›   is not a function
 ›       at CoreConsoleAPI.getApplicationExtensions (/usr/local/lib/node_module
 ›   s/@adobe/aio-cli/node_modules/@adobe/aio-lib-console/src/index.js:1337:10)
 ›       at LibConsoleCLI.getApplicationExtensions 
 ›   (/usr/local/lib/node_modules/@adobe/aio-cli/node_modules/@adobe/aio-cli-li
 ›   b-console/lib/index.js:123:51)
 ›       at Deploy.getApplicationExtension 
 ›   (/usr/local/lib/node_modules/@adobe/aio-cli/node_modules/@adobe/aio-cli-pl
 ›   ugin-app/src/commands/app/deploy.js:290:55)
 ›       at process.processTicksAndRejections 
 ›   (node:internal/process/task_queues:95:5)
 ›       at async Deploy.run (/usr/local/lib/node_modules/@adobe/aio-cli/node_m
 ›   odules/@adobe/aio-cli-plugin-app/src/commands/app/deploy.js:86:27)
 ›       at async Deploy._run (/usr/local/lib/node_modules/@adobe/aio-cli/node_
 ›   modules/@oclif/core/lib/command.js:117:22)
 ›       at async Config.runCommand (/usr/local/lib/node_modules/@adobe/aio-cli
 ›   /node_modules/@oclif/core/lib/config/config.js:329:25)
 ›       at async run (/usr/local/lib/node_modules/@adobe/aio-cli/node_modules/
 ›   @oclif/core/lib/main.js:89:16)
 ›       at async AIOCommand.run 
 ›   (/usr/local/lib/node_modules/@adobe/aio-cli/src/index.js:30:12)

The PR had a change to api.json that was apparently a large diff, and Github was not able to show any differences, so a review might have missed a change. Even if Github was able to show all changes, it would be hard to review.

The issue was fixed here: #100

Nevertheless, the tests should cover the case if the api spec was missing the spec for a binding that exists in the library, so this can never happen again.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions