Skip to content

[MOB-21074] Fix threading issues during map updates in updateProposition #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 6, 2024
Merged

[MOB-21074] Fix threading issues during map updates in updateProposition #87

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c1b51d2
[MOB-21074] Changing the hashmap to concurrent hashmap
siddique-adobe Jul 24, 2024
3e467b5
[MOB-21074] Changing the updateRequestEventIdsInProgress and proposit…
siddique-adobe Jul 26, 2024
df10e39
[MOB-21074] Commenting the reason for my code changes
siddique-adobe Jul 29, 2024
a799618
[MOB-21074] Adding the tests for making sure that the type of map is …
siddique-adobe Jul 29, 2024
692eff6
[MOB-21074] Removing the tests and updating the comments and data str…
siddique-adobe Jul 31, 2024
35964ed
[MOB-21074] Moving the cachedPropositions to declaration from initial…
siddique-adobe Aug 1, 2024
ab0b498
[MOB-21074] Comments updated
siddique-adobe Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions code/optimize/src/main/java/com/adobe/marketing/mobile/optimize/OptimizeExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,17 @@
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;

class OptimizeExtension extends Extension {

private static final String SELF_TAG = "OptimizeExtension";
private Map<DecisionScope, OptimizeProposition> cachedPropositions;

// Concurrent Map containing the cached propositions returned in various
// personalization:decisions events
// for the same Edge personalization request.
// This is accessed from multiple threads.
private Map<DecisionScope, OptimizeProposition> cachedPropositions = new ConcurrentHashMap<>();

// Events dispatcher used to maintain the processing order of update and get propositions
// events.
Expand All @@ -59,13 +65,18 @@ public boolean doWork(final Event event) {
}
});

// Map containing the update event IDs (and corresponding requested scopes) for Edge events that
// haven't yet received an Edge completion response.
private Map<String, List<DecisionScope>> updateRequestEventIdsInProgress = new HashMap<>();
// Concurrent Map containing the update event IDs (and corresponding requested scopes) for Edge
// events that haven't yet received an Edge completion response.
// This is accessed from multiple threads.
private final Map<String, List<DecisionScope>> updateRequestEventIdsInProgress =
new ConcurrentHashMap<>();

// a dictionary to accumulate propositions returned in various personalization:decisions events
// Concurrent Map to accumulate propositions returned in various personalization:decisions
// events
// for the same Edge personalization request.
private Map<DecisionScope, OptimizeProposition> propositionsInProgress = new HashMap<>();
// This is accessed from multiple threads.
private final Map<DecisionScope, OptimizeProposition> propositionsInProgress =
new ConcurrentHashMap<>();

// List containing the schema strings for the proposition items supported by the SDK, sent in
// the personalization query request.
Expand Down Expand Up @@ -107,8 +118,6 @@ public boolean doWork(final Event event) {
*/
protected OptimizeExtension(final ExtensionApi extensionApi) {
super(extensionApi);

cachedPropositions = new HashMap<>();
}

@Override
Expand Down Expand Up @@ -868,7 +877,8 @@ Map<DecisionScope, OptimizeProposition> getPropositionsInProgress() {
@VisibleForTesting
void setPropositionsInProgress(
final Map<DecisionScope, OptimizeProposition> propositionsInProgress) {
this.propositionsInProgress = propositionsInProgress;
this.propositionsInProgress.clear();
this.propositionsInProgress.putAll(propositionsInProgress);
}

@VisibleForTesting
Expand Down