[MOB-21074] Removing the tests and updating the comments and data str…

…ucture of cachedPropositions to ConcurrentHashMap from hashmap

code/optimize/src/main/java/com/adobe/marketing/mobile/optimize/OptimizeExtension.java

@@ -62,20 +62,18 @@ public boolean doWork(final Event event) {
 
     // Map containing the update event IDs (and corresponding requested scopes) for Edge events that
     // haven't yet received an Edge completion response.
-    // Updating the map type from Hashmap to ConcurrentHashMap to avoid the race condition to
-    // restrict it getting accessed by multiple threads
-    // Also declaring its reference as static and final because we have to make sure there is only
-    // one instance of the map for the singleton optimize extension class.
-    private static final Map<String, List<DecisionScope>> updateRequestEventIdsInProgress =
+    // Concurrent Map containing the update event IDs (and corresponding requested scopes) for Edge
+    // events that haven't yet received an Edge completion response.
+    // This is accessed from multiple threads.
+    private final Map<String, List<DecisionScope>> updateRequestEventIdsInProgress =
             new ConcurrentHashMap<>();
 
     // a dictionary to accumulate propositions returned in various personalization:decisions events
     // for the same Edge personalization request.
-    // Updating the map type from Hashmap to ConcurrentHashMap to avoid the race condition to
-    // restrict it getting accessed by multiple threads.
-    // Also declaring its reference as static and final because we have to make sure there is only
-    // one instance of the map for the singleton optimize extension class.
-    private static final Map<DecisionScope, OptimizeProposition> propositionsInProgress =
+    // Concurrent Map containing the get propositions (and corresponding requested scopes) for Edge
+    // events that are going to be pushed to the Edge network.
+    // This is accessed from multiple threads.
+    private final Map<DecisionScope, OptimizeProposition> propositionsInProgress =
             new ConcurrentHashMap<>();
 
     // List containing the schema strings for the proposition items supported by the SDK, sent in
@@ -118,8 +116,10 @@ public boolean doWork(final Event event) {
      */
     protected OptimizeExtension(final ExtensionApi extensionApi) {
         super(extensionApi);
-
-        cachedPropositions = new HashMap<>();
+        /// Concurrent Map containing the get propositions (and corresponding requested scopes) for
+        // Edge events that are yet to be pushed to the Edge network.
+        // This is accessed from multiple threads.
+        cachedPropositions = new ConcurrentHashMap<>();
     }
 
     @Override
@@ -879,8 +879,8 @@ Map<DecisionScope, OptimizeProposition> getPropositionsInProgress() {
     @VisibleForTesting
     void setPropositionsInProgress(
             final Map<DecisionScope, OptimizeProposition> propositionsInProgress) {
-        OptimizeExtension.propositionsInProgress.clear();
-        OptimizeExtension.propositionsInProgress.putAll(propositionsInProgress);
+        this.propositionsInProgress.clear();
+        this.propositionsInProgress.putAll(propositionsInProgress);
     }
 
     @VisibleForTesting

code/optimize/src/test/java/com/adobe/marketing/mobile/optimize/OptimizeExtensionTests.java

@@ -25,7 +25,6 @@
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
-import java.util.concurrent.ConcurrentHashMap;
 import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Test;
@@ -2153,15 +2152,4 @@ private void setConfigurationSharedState(
                                 ArgumentMatchers.eq(SharedStateResolution.ANY)))
                 .thenReturn(new SharedStateResult(status, data));
     }
-
-    @Test
-    public void testUpdateRequestEventIdsInProgressIsConcurrentHashMap() {
-        Assert.assertTrue(
-                (extension.getUpdateRequestEventIdsInProgress()) instanceof ConcurrentHashMap);
-    }
-
-    @Test
-    public void testPropositionsInProgressIsConcurrentHashMap() {
-        Assert.assertTrue(extension.getPropositionsInProgress() instanceof ConcurrentHashMap);
-    }
 }