Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove double URL encoding of AEPIdentity identifiers #659

Merged
merged 3 commits into from
Jun 29, 2021
Merged

Remove double URL encoding of AEPIdentity identifiers #659

merged 3 commits into from
Jun 29, 2021

Commits on Jun 29, 2021

  1. Fix tests to assert URLs are not double encoding CID delimiter

    @kevinlind
    kevinlind committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    4db1ab9 View commit details
    Browse the repository at this point in the history

  2. Remove encoding from URLQueryItems+Identity. 

    The url returned from URL+Identity is encoded when calling URLComponents.url. The encoding performed in URLQueryItems+Identity results in double encoding of the resulting url. Removing the encoding in URLQueryItems+Identity so the final url from URL+Identity is encoded only once.
    @kevinlind
    kevinlind committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    0e605cc View commit details
    Browse the repository at this point in the history

  3. Fix format

    @kevinlind
    kevinlind committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    30aea33 View commit details
    Browse the repository at this point in the history