Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove double URL encoding of AEPIdentity identifiers #659

Merged
merged 3 commits into from
Jun 29, 2021

Conversation

kevinlind
Copy link
Contributor

@kevinlind kevinlind commented Jun 29, 2021

Description

Remove the double encoding of URLs used in AEPIdentity. The double encoding caused URLs containing the CID delimiter '%01' to be encoded as '%2501'.

Internal ticket: AMSDK-11504

Related Issue

Motivation and Context

Customer reported issue. AEP Identity sync requests contain the incorrect CID delimiter. Instead of the out going URL using '%01', the delimiter was encoded to '%25'.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

The url returned from URL+Identity is encoded when calling URLComponents.url. The encoding performed in URLQueryItems+Identity results in double encoding of the resulting url. Removing the encoding in URLQueryItems+Identity so the final url from URL+Identity is encoded only once.
@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #659 (30aea33) into dev-v3.2.2 (c0781f1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           dev-v3.2.2     #659      +/-   ##
==============================================
- Coverage       85.35%   85.34%   -0.00%     
==============================================
  Files             105      105              
  Lines            4634     4633       -1     
==============================================
- Hits             3955     3954       -1     
  Misses            679      679              

@nporter-adbe nporter-adbe merged commit d7f4f2c into adobe:dev-v3.2.2 Jun 29, 2021
@kevinlind kevinlind deleted the amsdk-11504 branch June 29, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants