Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev to main - fix date formatting, better debug logging #438

Merged
merged 3 commits into from
Nov 2, 2020
Merged

dev to main - fix date formatting, better debug logging #438

merged 3 commits into from
Nov 2, 2020

Conversation

sbenedicadb
Copy link
Member

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sbenedicadb
#428 - prettier logs (#429)
15a6cd4 
* #428 - prettier logs

* -fix a format issue

* -disable indent warning for format in description method of event

* -increase timeout for a test and fix typo
@sbenedicadb
-fix date formatting and add tests (#434)
2dfd929 
* -fix date formatting and add tests

* -fix broken test

* -update names of timestamps to be more appropriate

* -fix timezone representation for GMT timezone

* -cleaner implementation of one of the date formatters

* -update test

* -try to fix test again

* -fix tests for real

* -trying to fix tests again

* -last fix

* -Z

* -done
@sbenedicadb
Merge branch 'main' into dev
bcee274
@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #438 into main will increase coverage by 0.33%.
The diff coverage is 94.29%.

@@            Coverage Diff             @@
##             main     #438      +/-   ##
==========================================
+ Coverage   87.10%   87.43%   +0.33%     
==========================================
  Files          92       92              
  Lines        4032     4042      +10     
==========================================
+ Hits         3512     3534      +22     
+ Misses        520      508      -12

@sbenedicadb sbenedicadb merged commit 51a6bd9 into main Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangyansong-adbe yangyansong-adbe yangyansong-adbe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbenedicadb @yangyansong-adbe