#428 - prettier logs #429
Merged
#428 - prettier logs #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbenedicadb
commented
Oct 27, 2020
| @@ -39,7 +39,17 @@ public class Event: NSObject, Codable { | |||
|
|
|||
| /// Event description used for logging | |||
| @objc override public var description: String { | |||
| return "id: \(id.uuidString) name: \(name) type: \(type) source: \(source) data: \(String(describing: data)) timestamp: \(timestamp.description) responseId: \(String(describing: responseID?.uuidString))" | |||
| // swiftformat:disable indent | |||
There was a problem hiding this comment.
this prevents warnings from SwiftFormat for the indentation used in the formatting of the Event's description
cdhoffmann
approved these changes
Oct 27, 2020
Codecov Report
@@ Coverage Diff @@
## dev #429 +/- ##
==========================================
+ Coverage 87.10% 87.14% +0.03%
==========================================
Files 92 92
Lines 4032 4042 +10
==========================================
+ Hits 3512 3522 +10
Misses 520 520 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: