#2128 trigger pause when media component leaves view

[jamesrea83]

In response to #2128.

As per this comment media component is paused directly, rather than triggering media:stop.

[moloko]

I think this behaviour should be configurable via a property. Question is: should it be enabled by default or not? Thoughts?

[brian-learningpool]

I agree this setting should be configurable via a property.

I was initially going to say defaulted to on, but I've changed my mind and gone with a default of off for two reasons:

• backwards compatibility (maintaining existing functionality)
• the Media component also handles playing MP3 files, where it's probably acceptable to continue playing while not in view

[moloko]

fine by me, tbh it’s not really an issue in the framework where this sort of thing is easily changed via find-and-replace, it’s more an issue for authoring tool users.

[jamesrea83]

@oliverfoster what do you think about attaching the listener only when playback starts, and removing it when it stops? As opposed to the current adding it to setupEventListeners / remove.

[oliverfoster]

@oliverfoster what do you think about attaching the listener only when playback starts, and removing it when it stops? As opposed to the current adding it to setupEventListeners / remove.

It would be preferable from a CPU usage perspective to attach the inview listeners only when they are needed but could also make for more sprawling code. Having good names and layouts of the functions would mitigate the secondary layer of event attachments / removals and you will still need to remove the event attachments when the component is destroyed.

Really, it's only a CPU problem if you have loads of things listening for inview at the same time. It might be worth leaving the code as it is, it's nice and simple.

[danielstorey]

Looks great! Couple of really minor comments

[moloko]

code 👁