Add media:stop triggers on notify and drawer

[danielghost]

Should the media:stop event be triggered more often in core Adapt?

Is it good design to leave video/audio playing when the drawer is opened, tutor feedbacks displayed etc., or should we stop this as default? You could argue that video shouldn't be played when no longer inview, so scrolling past a media component should potentially stop this.

From a quick look around, some websites seem to continue to let video play when no longer inview or a popup has been displayed, some seem to show a smaller thumbnail style version of the video fixed to the bottom corner as you scroll past the main video.

As we are generally building learning content in Adapt, my initial thoughts would be that if you are no longer physically watching the video, it seems odd for it to continue to play. Maybe the counter argument is that it is best to leave this to the user to decide, as they can always stop the video before clicking elsewhere etc.

[oliverfoster]

Yup, totally.
It's relatively new and unmaintained at the mo.

[moloko]

@danielghost I think the main reason would be the lack of consensus on when exactly media should be stopped.

I find it easiest just to do this as and when required on a project according to the designer's/client's requirements.

[chetan-hajare]

Agree with you @danielghost
During the course development we had the requirements of stopping the video when not in view but played when drawer gets opened so better there should be an option available to the course creator when to play/stop the video.

[moloko]

stopping video when it scrolls out of view would be a modification to the media component rather than anything to do with media:stop. Sounds like a useful addition to the media component to me; if someone wants to log a ticket I'm sure someone will pick that up.

[oliverfoster]

related to #1653
media pause on popup open (drawer and notify)