Update: Control content max width via variable (fixes #260) #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 2, 2022
Merged
oliverfoster
approved these changes
Dec 5, 2022
Member
oliverfoster
left a comment
oliverfoster
left a comment
There was a problem hiding this comment.
Comment about difference between content and page
guywillis
requested review from
StuartNicholls,
eleanor-heath and
kirsty-hames
kirsty-hames
approved these changes
Dec 6, 2022
Contributor
|
Should the Vanilla, BoxMenu and LanguagePicker get a FW dependency bump when this is merged and FW gets released with it? |
Contributor
Author
|
@cahirodoherty-learningpool yes, they will need a FW dependency bump |
StuartNicholls
approved these changes
Dec 7, 2022
eleanor-heath
approved these changes
Dec 7, 2022
|
🎉 This PR is included in version 6.23.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #260
Update
@max-content-width, set to inherit@device-width-large@max-page-width, set to inherit@max-width.l-container-responsive(@device-width-large);to.l-container-responsive(@max-content-width);.l-container-responsive(@max-width);to.l-container-responsive(@max-page-width);Dependencies