Skip to content

Update: Control content max width via variable (fixes #130) #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oliverfoster merged 3 commits into from
Dec 7, 2022
Merged

Update: Control content max width via variable (fixes #130) #131

oliverfoster merged 3 commits into from
Dec 7, 2022

Conversation

@guywillis
Copy link
Contributor

@guywillis guywillis commented Dec 2, 2022 •
edited
Loading

Fixes: #130

Update

  • Changed @max-width to @max-page-width
  • Changed @device-width-large to @max-content-width

Dependencies

@guywillis guywillis self-assigned this Dec 2, 2022
This was referenced Dec 2, 2022
Merged
Merged
Merged
@oliverfoster
Copy link
Member

oliverfoster commented Dec 5, 2022

Requires adapt_framework bump after core release

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@cahirodoherty-learningpool cahirodoherty-learningpool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit ea97125 into master Dec 7, 2022
@oliverfoster oliverfoster deleted the issue/130 branch December 7, 2022 15:13
github-actions bot pushed a commit that referenced this pull request Dec 7, 2022
@semantic-release-bot
Chore(release): 6.2.0 [skip ci]
0b4bb5d 
# [6.2.0](v6.1.0...v6.2.0) (2022-12-07)

### Update

* Control content max width via variable (fixes #130) (#131) ([ea97125](ea97125)), closes [#130](#130) [#131](#131)
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

🎉 This PR is included in version 6.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StuartNicholls StuartNicholls StuartNicholls approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@eleanor-heath eleanor-heath eleanor-heath approved these changes

Assignees

@guywillis guywillis

Labels

enhancement released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Control content max width via variable

7 participants

@guywillis @oliverfoster @StuartNicholls @kirsty-hames @cahirodoherty-learningpool @eleanor-heath