Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements: upgrade numpy and jax #34

Merged
merged 5 commits into from
Jun 23, 2022

Conversation

felixchalumeau
Copy link
Collaborator

This PR updates several requirements. It was initially created to address the GitHub dependabot security issue to do with the numpy version.

It also increases the jax version to 0.3.10

Notes:

  • the performances where quickly checked with a few seeds on PGAME but in the future it is important that we set up a way to check up the performance of most of the algorithms on several environments to make sure the performance is not impacted by version changes (and also by usual PRs)
  • this PR has the same commits as Update requirements.txt file #26, they were basically cherry-picked to have a branch out and in develop instead of master

@felixchalumeau felixchalumeau marked this pull request as ready for review June 23, 2022 08:41
Copy link
Collaborator

@limbryan limbryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in PR note: follows up from a previous PR but to push to develop instead of main.

@felixchalumeau felixchalumeau merged commit c631303 into develop Jun 23, 2022
@limbryan limbryan deleted the requirement_update branch July 4, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants