Fix pareto dominance definition #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess values are same along one axis
Lookatator
requested changes
Jan 30, 2024
There was a problem hiding this comment.
Hi @hannah-jan
Thank you very much for the PR!
There seems to be a test that does not pass because the variable mask seems undefined?
Apart from that it looks good to me! 😃
…nd compute_masked_pareto_dominance
|
Hello!! @Lookatator thanks for the comment!! Sorry I did it in a rush (classic me) so put it in the wrong definition. Both Pareto Dominance definitions should be updated now |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #174 +/- ##
===========================================
- Coverage 92.31% 90.96% -1.36%
===========================================
Files 103 125 +22
Lines 5816 7657 +1841
===========================================
+ Hits 5369 6965 +1596
- Misses 447 692 +245 ☔ View full report in Codecov by Sentry. |
Lookatator
approved these changes
Feb 8, 2024
Lookatator
merged commit 30ea208
into
adaptive-intelligent-robotics:develop
5 checks passed
Lookatator
added a commit
that referenced
this pull request
Sep 6, 2024
* feat(algo): add DCG-MAP-Elites whose most recent version is called DCRL-ME (#167) * fix: Fix pareto dominance definition to account for solutions which have the same fitness values along one axis (#174) * docs(contribution): clarify contribution process (#171) * feat: Upgrade Library Versions and Python Version (#187) --------- Co-authored-by: Maxence Faldor <m.faldor22@imperial.ac.uk> Co-authored-by: Hannah Janmohamed <hannah.janmohamed21@imperial.ac.uk> Co-authored-by: Felix Chalumeau <f.chalumeau@instadeep.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
pareto_front.pyto account for solutions which have the same fitness values along one axis.