Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/sampling extractors #158

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Feat/sampling extractors #158

merged 1 commit into from
Nov 27, 2023

Conversation

manon-but-yes
Copy link
Collaborator

@manon-but-yes manon-but-yes commented Oct 24, 2023

Related issues: \

Make the structure of the sampling function more general to allow the user to specify the estimator for the expectations and reproducibility. Also propose some implementations a few commonly used estimators.

This PR introduces:

  • Modify the sampling function to take two additional arguments: the fitness extractor and the descriptor extractor
  • Provide 4 expectation extractors: average, median, mode and closest, and 3 reproducibility extractors: std, mad and iqr
  • Define a new sampling_reproducibility function that returns both the expectations and reproducibility of fitness and descriptor
  • Update the sampling testing to test these additions

Checks

  • a clear description of the PR has been added
  • sufficient tests have been written
  • relevant section added to the documentation
  • example notebook added to the repo
  • clean docstrings and comments have been written
  • if any issue/observation has been discovered, a new issue has been opened

Future improvements

The functions used by MAP-Elites Low-spread could be define as extractor in sampling.py as well to avoid code duplication.

@manon-but-yes manon-but-yes changed the base branch from main to develop October 24, 2023 12:35
@manon-but-yes manon-but-yes requested review from btjanaka and removed request for Lookatator October 24, 2023 12:38
@manon-but-yes manon-but-yes removed the request for review from btjanaka November 27, 2023 18:07
@manon-but-yes manon-but-yes merged commit a63df5b into develop Nov 27, 2023
1 check passed
@Lookatator Lookatator deleted the feat/sampling_extractors branch September 1, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants