Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/scikit learn requirement #132

Merged
merged 4 commits into from
Dec 7, 2022
Merged

Conversation

felixchalumeau
Copy link
Collaborator

@felixchalumeau felixchalumeau commented Dec 6, 2022

Copy from #131

switched depreciated dependency sklearn -> scikit-learn

Related issues: #130

The PR replaces the depreciated sklearn package with scikit-learn.

Checks

  • a clear description of the PR has been added
  • sufficient tests have been written
  • relevant section added to the documentation
  • example notebook added to the repo
  • clean docstrings and comments have been written
  • if any issue/observation has been discovered, a new issue has been opened

Future improvements

N/A

mplemay and others added 2 commits December 2, 2022 09:25
switched depreciated dependency sklearn -> scikit-learn
switched depreciated dependency sklearn -> scikit-learn
@codecov-commenter
Copy link

Codecov Report

Merging #132 (b9183d5) into main (fc0ad78) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage   92.31%   92.31%           
=======================================
  Files         103      103           
  Lines        5816     5816           
=======================================
  Hits         5369     5369           
  Misses        447      447           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@felixchalumeau felixchalumeau marked this pull request as ready for review December 7, 2022 09:21
requirements.txt Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@Lookatator Lookatator merged commit f366797 into main Dec 7, 2022
@Lookatator Lookatator deleted the hotfix/scikit-learn-requirement branch December 7, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants