Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/docs ci #112

Merged
merged 5 commits into from
Nov 22, 2022
Merged

Fix/docs ci #112

merged 5 commits into from
Nov 22, 2022

Conversation

felixchalumeau
Copy link
Collaborator

@felixchalumeau felixchalumeau commented Nov 22, 2022

In the docs building, setup.py overrides some dependencies from requirements. In this case, flax was updated to 0.6.2 where a change has been introduced to PyTreeNode, causing the issue when a class inheriting from PyTreeNode was parsed for auto-docstrings.

Was also necessary to ping other mkdocstrings dependencies.

Should be fixed now. Issue opened in flax to have more information about their recent change.

@felixchalumeau felixchalumeau changed the base branch from main to develop November 22, 2022 16:36
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2022

Codecov Report

Merging #112 (6fe3568) into develop (aee7e51) will not change coverage.
The diff coverage is n/a.

❗ Current head 6fe3568 differs from pull request most recent head 65be74e. Consider uploading reports for the commit 65be74e to get more accurate results

@@           Coverage Diff            @@
##           develop     #112   +/-   ##
========================================
  Coverage    90.69%   90.69%           
========================================
  Files           84       84           
  Lines         4677     4677           
========================================
  Hits          4242     4242           
  Misses         435      435           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@felixchalumeau felixchalumeau marked this pull request as ready for review November 22, 2022 19:08
@felixchalumeau felixchalumeau merged commit 46e82b6 into develop Nov 22, 2022
@limbryan limbryan deleted the fix/docs-ci branch November 30, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants