Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.4.0 release #453

Closed
14 tasks done
adamralph opened this issue Dec 21, 2020 · 2 comments
Closed
14 tasks done

2.4.0 release #453

adamralph opened this issue Dec 21, 2020 · 2 comments
Milestone

Comments

@adamralph
Copy link
Owner

adamralph commented Dec 21, 2020

@adamralph adamralph added this to the 2.4.0 milestone Dec 21, 2020
@augustoproiete
Copy link

augustoproiete commented Dec 22, 2020

@adamralph I tested the usage of environment variables with minver-cli 2.4.0-beta.2 and it all works as expected.

minver-cli uses environment variables when present

Environment variable Case-insensitive
MinVerAutoIncrement MINVERAUTOINCREMENT
MinVerBuildMetadata MINVERBUILDMETADATA
MinVerDefaultPreReleasePhase MINVERDEFAULTPRERELEASEPHASE
MinVerMinimumMajorMinor MINVERMINIMUMMAJORMINOR
MinVerTagPrefix MINVERTAGPREFIX
MinVerVerbosity MINVERVERBOSITY
MinVerVersionOverride MINVERVERSIONOVERRIDE

minver-cli command-line arguments override environment variables when present

Environment variable Command-line argument
MinVerAutoIncrement --auto-increment
MinVerBuildMetadata --build-metadata
MinVerDefaultPreReleasePhase --default-pre-release-phase
MinVerMinimumMajorMinor --minimum-major-minor
MinVerTagPrefix --tag-prefix
MinVerVerbosity --verbosity

Some edge-cases I could think of:

1. Environment variable is present, but I want to ignore it and use an empty value

e.g.

set MINVERBUILDMETADATA=ABC
set MINVERTAGPREFIX=DEF
minver --build-metadata "" --tag-prefix ""

✅ I confirmed it will use empty values instead of using the environment variables

2. MINVERVERSIONOVERRIDE correctly overrides the version (even when other environment variables) are present, but I want to opt-out of this, and let minver do its thing

⚠️ There's no way of opting out of this via the CLI... One would have to redefine the environment variable value in the build script before calling minver, but that seems OK to me.


:shipit: 🚀

@adamralph
Copy link
Owner Author

adamralph commented Dec 22, 2020

Wow, thanks for the detailed testing @augustoproiete!

Regarding MINVERVERSIONOVERRIDE, I think the current behaviour makes sense, since that option is not intended to be used as a command line argument, but rather only as an environment variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants