-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use environment variables in minver-cli #450
Labels
enhancement
New feature or request
Milestone
Comments
This was referenced Dec 21, 2020
Released in 2.4.0-beta.1. @augustoproiete please give it a try. |
Cheers @adamralph! I will take it for a spin! Update: Test results |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thanks to @augustoproiete for raising #423 for
MinVerBuildMetadata
, which led to this more general enhancement.The
MinVer
package accepts options as environment variables. This is standard .NET SDK behaviour: all environment variables are propagated as MSBuild properties.With this enhancement, the
minver-cli
package does the same thing.There is one exception:
MinVerSkip
. This option effectively switches off theMinVer
package, which means none of the output properties will be set, which means the SDK will use whatever version is set via aVersion
property, whether that is explicitly done for a project, or implicitly done by the SDK as a default value. There is no good equivalent forminver-cli
. If the command line were "switched off", then the equivalent behaviour would be to return no value. If a user wants to "switch off" theminver-cli
package, then they can observeMinVerSkip
themselves and provide an alternate version string in that scenario.The text was updated successfully, but these errors were encountered: