Skip to content

Fix incorrect check in issuer_or_subject_length function #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 2, 2025
Merged

Fix incorrect check in issuer_or_subject_length function #40

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
008b548
Fix incorrect logic in issuer_or_subject_length function
akgamerz790 Nov 2, 2025
adb555a
Change exception type from TypeError to ValueError; check for negativ…
dhalbert Nov 2, 2025
d12e6b1
fix whitespace
dhalbert Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions adafruit_atecc/adafruit_atecc_asn1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ def issuer_or_subject_length(
:param str org: Organization of certificate
:param str org_unit: Organization unit of certificate
:param str common: Common data of certificate
:raises: TypeError if return value is 0
:raises: ValueError if return value is <= 0
:return: Total length of provided certificate information.
"""
tot_len = 0
Expand All @@ -268,6 +268,7 @@ def issuer_or_subject_length(
tot_len += 11 + len(org_unit)
if common:
tot_len += 11 + len(common)
else:
raise TypeError("Provided length must be > 0")

if tot_len <= 0:
raise ValueError("Provided length must be > 0")
return tot_len